Relation refactor #375
Open
Relation refactor #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we specify a custom agreggate (max, avg, min, ...) use this aggregate for filtering data Also fix filtering when null values are returned with aggregates
formats & rounds a number with grouped thousands - 1000000 => 1,000,000.00 (If places set to 2) with variable places.
The highlight call is currently executed after the export callback, making it impossible to strip out the highlighting markup that is added for search results. Moving the highlighting before the export callbacks resolves this.
The highlight call is currently executed after the export callback, making it impossible to strip out the highlighting markup that is added for search results. Moving the highlighting before the export callbacks resolves this.
Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: Herbert Maschke <[email protected]>
* Fix applied * StyleCI * Bit neater Co-authored-by: Rik Thomas <[email protected]>
- Set variable $useThrough AFTER checking if relation is an instance of HasMany, HasManyThrough or BelongsToMany. Otherwise, it will return an error because no joins property exists for $this->query->getQuery()
Add table prefix to the table variable in the customWithAggregate and hasAggregate EloquentBuilder macros registerd by the service provider.
Added defaultFilters to Livewire Datatables
Bugfix checkboxes behavior when search or filters are active - If the search or filter is active, we must display the count of checked rows only for "visible" items (results of search or filtered results). Therefore, the toggleSelectAll() method must also check or uncheck all "visible" items when the search or filters are active.
check which database driver is used and build the query according to its dialect. added SQLite dialect only, partially fiexs issue #183
Fix to prevent addGlobalSearch method to prepend tablePrefix when column contains '_concat_'. It was generating a syntax error in the query, i.e.: SQLSTATE[42000]: Syntax error or access violation: 1305 FUNCTION **DBNAME**.**TABLEPREFIX**CONCAT_WS does not exist
Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: StyleCI Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.